If connectSocket() completes directly we need to mark channel as active #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add a test... |
Motivation: If connectSocket() completes directly we failed to mark the Channel active by calling becomeActive0(...). Modifications: Correctly call becomeActive0(...) Result: Mark Channel active if connect succeed directly.
normanmaurer
force-pushed
the
non_delayed_connect_active
branch
from
0a20349 to
b71b55d
Compare
Lukasa
approved these changes
Mar 20, 2018
|
@Lukasa we can investigate but I think we really should not do this as calling getsockopt here is really a waste if not needed and its an easy "fix" |
|
Ok :) |
weissi
pushed a commit
to weissi/swift-nio
that referenced
this pull request
Jun 13, 2020
Motivation: As part of apple#202 we added support for configuring the target window size of stream channels. That was plumbed through into outbound channels, but we missed the inbound ones, meaning that this only really worked for clients, not servers. That hardly seems fair! Modifications: Pass target window size to inbound channels too. Result: We can control target window size of inbound channels.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If connectSocket() completes directly we failed to mark the Channel active by calling becomeActive0(...).
Modifications:
Correctly call becomeActive0(...)
Result:
Mark Channel active if connect succeed directly.