Changed EventLoop{Future,Promise}<()> occurances to EventLoop{Future,Promise}<Void> (#211) #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Promise}<Void> (#211) Motivation: Fix inconsistency of <Void> and <()> occurances in the codebase. Modifications: Changed EventLoop{Future,Promise}<()> occurances to EventLoop{Future,Promise}<Void> Result: Consistent code style for EventLoopPromise and EventLoopFuture.
|
Can one of the admins verify this patch? |
normanmaurer
approved these changes
Mar 22, 2018
|
@swift-nio-bot test this please |
Lukasa
approved these changes
Mar 22, 2018
|
@tib thanks a lot! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Fix inconsistency of and <()> occurances in the codebase. (fixes #211)
Modifications:
Changed EventLoop{Future,Promise}<()> occurances to EventLoop{Future,Promise}
Result:
Consistent code style for EventLoopPromise and EventLoopFuture.
All tests have been passed.