Fix last remaining test on Android #2457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Get all tests passing on Android AArch64
Modifications:
localhost
is set for IPv6 inBootstrapTest/testClientBindWorksOnSocketsBoundToEitherIPv4OrIPv6Only
, and useip6-localhost
if notResult:
All tests pass natively on Android AArch64
The problem is that the localhost definitions in
/etc/hosts
on Android look like this, so I've long disabled this test on my Android CI:Whereas this test passed on linux because it defines
localhost
for both protocols:Binging it online, I see that Darwin doesn't appear to defineI only tested this change natively on Android, so let's see if the CI catches anything on linux and macOS.ip6-localhost
, so I kept that the same.