Rename the waitForFinalResult() methods and provide an ELF convenience
#2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
reviewed
Jul 27, 2023
FranzBusch
force-pushed
the
fb-rename-protocol-negotiation
branch
from
0c66748 to
8953d0f
Compare
rnro
approved these changes
Jul 28, 2023
FranzBusch
force-pushed
the
fb-rename-protocol-negotiation
branch
from
8953d0f to
f96fde0
Compare
glbrntt
approved these changes
Jul 28, 2023
…ience # Motivation The name `waitForFinalResult()` is bad in a couple of ways. First, we normally use `wait` for blocking operations. Secondly, `finalResult` is also just strange because the user only wants to know the _result_ and doesn't even know that there might be intermediates. # Modification This PR renames the `waitForFinalResult()` method to be a property on `NIOProtocolNegotiationResult`. Additionally, it provides a conditional extension on `ELF` to avoid a `get()`. # Result Better naming for our async interfaces
FranzBusch
force-pushed
the
fb-rename-protocol-negotiation
branch
from
e8faac7 to
6765dfd
Compare
FranzBusch
added
🔨 semver/patch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The name
waitForFinalResult()is bad in a couple of ways. First, we normally usewaitfor blocking operations. Secondly,finalResultis also just strange because the user only wants to know the result and doesn't even know that there might be intermediates.Modification
This PR renames the
waitForFinalResult()method to be a property onNIOProtocolNegotiationResult. Additionally, it provides a conditional extension onELFto avoid aget().Result
Better naming for our async interfaces