Get Android building again after #2479 #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation NIO wasn't building on Android Modifications - Add the right checks for Android Result Built and passed all tests on Android AArch64
1proprogrammerchant
added a commit
to 1proprogrammerchant/swift-nio
that referenced
this pull request
Aug 6, 2023
Get Android building again after apple#2479 (apple#2490)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
NIO wasn't building on Android
Modifications
Result
Built and passed all tests on Android AArch64
@3405691582 and @kateinoigakukun, I don't know if you two build NIO on BSD and WASM, but feel free to add or indicate changes to keep NIO working there too.