Bump minimum Swift version to 5.7 #2524
Conversation
Motivation: Now that Swift 5.9 is GM we should update the supported versions and remove 5.6 Modifications: * Update `Package.swift` * Remove `#if swift(>=5.7)` guards * Delete the 5.6 docker compose file and make a 5.10 one * Update integration test script * Update docs Result: Remove support for Swift 5.6, add 5.10
| @@ -3,28 +3,27 @@ version: "3" | |||
| services: | |||
There was a problem hiding this comment.
In addition to this, do you want to update the Swift 5.9 pipeline to use a release rather than nightly image?
|
CI changes applied:
@swift-server-bot test this please |
|
@swift-server-bot test this please |
Sources/NIOCore/EventLoop.swift
Outdated
| @usableFromInline typealias CancelationCallback = () -> Void | ||
| #endif | ||
| /* private but usableFromInline */ @usableFromInline let _promise: EventLoopPromise<T> | ||
| /* private but usableFromInline */ @usableFromInline let _promise: EventLoopPromise<T> |
There was a problem hiding this comment.
Indentation here got weird.
Sources/NIOCore/EventLoop.swift
Outdated
| typealias RepeatedTaskCallback = (RepeatedTask) -> EventLoopFuture<Void> | ||
| #endif | ||
| private let delay: TimeAmount | ||
| private let delay: TimeAmount |
There was a problem hiding this comment.
Indentation here also got weird.
| internal typealias Element = () -> CallbackList | ||
| #endif | ||
| @usableFromInline | ||
| @usableFromInline |
There was a problem hiding this comment.
same indentation issue here.
| @usableFromInline typealias WhenCompleteCallback = (Result<Value, Error>) -> Void | ||
| #endif | ||
| @inlinable | ||
| @inlinable |
There was a problem hiding this comment.
Same indentation issue here.
Sources/NIOPosix/Bootstrap.swift
Outdated
| private var protocolHandlers: Optional<() -> [ChannelHandler]> | ||
| #endif | ||
| private var _channelInitializer: ChannelInitializerCallback | ||
| private var _channelInitializer: ChannelInitializerCallback |
There was a problem hiding this comment.
Same indentation issue here.
Sources/NIOPosix/NIOThreadPool.swift
Outdated
| public typealias WorkItem = (WorkItemState) -> Void | ||
| #endif | ||
| private enum State { | ||
| private enum State { |
There was a problem hiding this comment.
Same indentation issue here.
| private typealias UpgradePipelineHandler = (Channel, HTTPRequestHead) -> EventLoopFuture<Void> | ||
| #endif | ||
| /// RFC 6455 specs this as the required entry in the Upgrade header. | ||
| /// RFC 6455 specs this as the required entry in the Upgrade header. |
There was a problem hiding this comment.
Same indentation issue here.
|
Thanks for the indentation catches @Lukasa, I went back over my diff and found a couple more. |
Motivation:
Now that Swift 5.9 is GM we should update the supported versions and remove 5.6
Modifications:
Package.swift#if swift(>=5.7)guardsResult:
Remove support for Swift 5.6, add 5.10
[One line description of your change]
Motivation:
[Explain here the context, and why you're making that change. What is the problem you're trying to solve.]
Modifications:
[Describe the modifications you've done.]
Result:
[After your change, what will change.]