Fix Sendable conformance for Lock
#2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation The latest nightly toolchains have merged the patch that removes `Sendable` conformance from the various `Unsafe*Pointer` APIs. Our `Lock` type was using such a type internally and had a `Sendable` conformance. This conformance was now failing since the pointer was no longer `Sendable`. # Modification This PR changes the `Sendable` conformance of `Lock` to `@unchecked Sendable`. # Result No more `Sendable` warnings in non-strict mode on nightly toolchains
Lukasa
approved these changes
Oct 16, 2023
dnadoba
approved these changes
Oct 16, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The latest nightly toolchains have merged the patch that removes
Sendableconformance from the variousUnsafe*PointerAPIs. OurLocktype was using such a type internally and had aSendableconformance. This conformance was now failing since the pointer was no longerSendable.Modification
This PR changes the
Sendableconformance ofLockto@unchecked Sendable.Result
No more
Sendablewarnings in non-strict mode on nightly toolchains