Make ByteBufferQUICBinaryEncodingStrategyTests compatible with 32-bit systems #2904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Oct 4, 2024
|
Thanks, I can confirm this pull fixed the 32-bit compilation issue for Android armv7. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #2867
Some of the literals used in the test cases were too big to fit in an Int32
This is fine on 64-bit systems, because the literals are considered as
Int, which is Int64 on those systemsHowever, on 32-bit systems, those literals are considered as Int64
Change: Add
as Int64where needed, to tell the compiler we want these literals to be treated as Int64, which should allow these tests to run on 32 bit systems too