rename HTTPHeaders.getCanonicalForm to subject and improve efficiency #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
HTTPHeaders had an unusual API for Swift: `getCanonicalForm(String)` which is
better suited as a subscript `[canonicalForm: String]`.
Also the implementation was needlessly inefficient.
Modifications:
- renamed HTTPHeaders.getCanonicalForm to HTTPHeaders[canonicalForm]
- improved efficiency by replacing anti-pattern
Array.map { ... }.reduce(+, []) by flatMap
Result:
more Swift in both meanings
weissi
commented
Apr 9, 2018
| // It's not safe to split Set-Cookie on comma. | ||
| let queryName = name.lowercased() | ||
| if queryName == "set-cookie" { | ||
| return self[name] | ||
| } | ||
|
|
||
| if let result = storage[queryName] { | ||
| return result.map { tuple in tuple.1.split(separator: ",").map { String($0.trimWhitespace()) } }.reduce([], +) | ||
| return result.flatMap { tuple in tuple.1.split(separator: ",").map { String($0.trimWhitespace()) } } |
There was a problem hiding this comment.
this is the only non-renaming change
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
HTTPHeaders had an unusual API for Swift:
getCanonicalForm(String)which isbetter suited as a subscript
[canonicalForm: String].Also the implementation was needlessly inefficient.
Modifications:
Array.map { ... }.reduce(+, []) by flatMap
Result:
more Swift in both meanings