EmbeddedEventLoop/Channel: check correct thread #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
force-pushed
the
jw-2949
branch
2 times, most recently
from
71cab13 to
03e324d
Compare
Lukasa
approved these changes
Oct 24, 2024
| } | ||
| #else | ||
| func isCorrectThread() -> Bool { | ||
| true // let's be conservative |
There was a problem hiding this comment.
By "conservative" this means "keep working"?
There was a problem hiding this comment.
Yeah, I did actually want to reword this -- and forgot.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
EmbeddedChannel&EmbeddedEventLoopcurrently violateSendable. They should store the current thread ininitand then implementinEventLoopand other functions with a check that the current thread is correct.Since NIO 1.0
Embedded*were always documented to not be thread-safe but we should finally police this.Modifications:
EmbeddedEventLooprequirements #2950)Result:
init()and then assert that we're on that thread #2949