Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix SemVer major label check #2970

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix SemVer major label check #2970

merged 1 commit into from
Nov 12, 2024

Conversation

FranzBusch
Copy link
Member

No description provided.

@FranzBusch FranzBusch added ⚠️ semver/major Breaks existing public API. semver/none No version bump required. and removed ⚠️ semver/major Breaks existing public API. labels Nov 12, 2024
@FranzBusch FranzBusch enabled auto-merge (squash) November 12, 2024 13:18
glbrntt
glbrntt approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we've rolled this label out to all repos?

@FranzBusch
Copy link
Member Author

I assume we've rolled this label out to all repos?

Yes. The label has been rolled out to all of our repos.

@FranzBusch FranzBusch merged commit 2139438 into main Nov 12, 2024
44 of 46 checks passed
@FranzBusch FranzBusch deleted the fb-semver-major-label-check branch November 12, 2024 13:35
Lukasa pushed a commit to Lukasa/swift-nio that referenced this pull request Nov 22, 2024
@FranzBusch @Lukasa
Fix SemVer major label check (apple#2970)
4b9cfec 
(cherry picked from commit 2139438)
@0xTim 0xTim mentioned this pull request Jan 16, 2025
Merged
@0xTim 0xTim mentioned this pull request Feb 23, 2025
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
semver/none No version bump required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FranzBusch @glbrntt