EventLoopFuture.waitSpinningRunLoop() #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
force-pushed
the
jw-wait-runloop
branch
from
6d5f73b to
71cf700
Compare
weissi
force-pushed
the
jw-wait-runloop
branch
4 times, most recently
from
8798791 to
6dccd4e
Compare
Lukasa
requested changes
Nov 21, 2024
weissi
force-pushed
the
jw-wait-runloop
branch
from
6dccd4e to
2617394
Compare
Lukasa
approved these changes
Nov 21, 2024
|
Note that the unit tests aren't passing. |
weissi
force-pushed
the
jw-wait-runloop
branch
from
2617394 to
b3daca6
Compare
Lukasa
pushed a commit
to Lukasa/swift-nio
that referenced
this pull request
Nov 22, 2024
### Motivation: In some (probably niche) scenarios, especially in pre-Concurrency UI applications on Darwin, it can be useful to wait for an a value whilst still running the current `RunLoop`. That allows the UI and other things to work whilst we're waiting for a future to complete. ### Modifications: - Add `NIOFoundationCompat.EventLoopFuture.waitSpinningRunLoop()`. ### Result: Better compatibility with Cocoa. (cherry picked from commit 2a8811a)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In some (probably niche) scenarios, especially in pre-Concurrency UI applications on Darwin, it can be useful to wait for an a value whilst still running the current
RunLoop. That allows the UI and other things to work whilst we're waiting for a future to complete.Modifications:
NIOFoundationCompat.EventLoopFuture.waitSpinningRunLoop().Result:
Better compatibility with Cocoa.