Ensure we test the isolated fallback methods #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation I'm about to change all our main event loops to use our new customisation points. That's great, but it'll have the effect of removing all the testing of our default implementations, which is not a good idea. So let's add some more tests. Modifications Define a "fallback" event loop for testing the isolated methods. Result Reduced likelihood of regressions in future.
glbrntt
approved these changes
Jan 20, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I'm about to change all our main event loops to use our new customisation points. That's great, but it'll have the effect of removing all the testing of our default implementations, which is not a good idea. So let's add some more tests.
Modifications
Define a "fallback" event loop for testing the isolated methods.
Result
Reduced likelihood of regressions in future.