Update nightly CI pipelines to 6.1 instead of 6.0 #3076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Active development has moved to 6.1 so the Swift 6.0 nightlies no longer deliver much value. Modifications: * Deprecate 6.0 nightly CI configuration parameters * Introduce new 6.1 nightly CI configuration parameters * Update the matrix generation script to handle 6.1 Result: * No more nightly 6.0 CI, 6.1 nightlies are introduced. * Configuration for 6.0 nightlies no longer has any effect. * All repos are automatically opted-in to 6.1 nightly linux pipelines **even if they opted out of 6.0**.
rnro
force-pushed
the
nightly_ci_to_6_1
branch
from
05a5b53 to
450caff
Compare
Lukasa
reviewed
Jan 21, 2025
| @@ -29,11 +29,19 @@ on: | |||
| default: "" | |||
| linux_nightly_6_0_enabled: | |||
| type: boolean | |||
| description: "Boolean to enable the Linux nightly 6.0 Swift version matrix job. Defaults to true." | |||
| description: "⚠️ Deprecated, we no longer run against 6.0 nightly." | |||
There was a problem hiding this comment.
Should these defaults be changed?
There was a problem hiding this comment.
I don’t think it matters, we just drop it on the floor now
Lukasa
approved these changes
Jan 21, 2025
rnro
added a commit
that referenced
this pull request
Jan 22, 2025
### Motivation: Some changes were missed in #3076, passing through parameters for the new 6.1 version. ### Modifications: Pass through more parameters, clean up misleading comments. ### Result: 6.1 nightly runs will be more like 6.0 nightly runs were
euanh
added a commit
to apple/swift-container-plugin
that referenced
this pull request
Jan 27, 2025
Motivation ---------- The shared unit test workflow has been updated to run on Swift 6.1 nightlies: apple/swift-nio#3076 A new `linux_nightly_6_1_arguments_override` parameter must be set to skip the smoke tests when running unit tests in CI. Modifications ------------- Define `linux_nightly_6_1_arguments_override` to ignore smoke tests. Remove `linux_nightly_6_0_arguments_override` which is no longer used. Result ------ Tests, including the daily test runs, will pass again. Test Plan --------- This fixes a test failure caused by the upstream shared workflows being changed. All tests now pass again.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Active development has moved to 6.1 so the Swift 6.0 nightlies no longer deliver much value.
Modifications:
Result: