Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

undo Xcode 13 GM workaround #3092

Merged
merged 1 commit into from
Jan 28, 2025
Merged

undo Xcode 13 GM workaround #3092

merged 1 commit into from
Jan 28, 2025

Conversation

weissi
Copy link
Member

@weissi weissi commented Jan 27, 2025

Motivation:

Xcode 13 is really quite old (3 major releases and it was the GM release anyway) and this workaround can cause other issues.

Modifications:

  • Remove the Xcode 13 GM workaround.

Result:

Better, possibly faster code.

@weissi weissi requested a review from Lukasa January 27, 2025 22:04
@weissi weissi marked this pull request as draft January 27, 2025 22:20
@weissi
Copy link
Member Author

weissi commented Jan 27, 2025

oha, this actually trigger a compiler crash :|

@weissi weissi marked this pull request as ready for review January 27, 2025 23:11
@weissi
Copy link
Member Author

weissi commented Jan 27, 2025

oha, this actually trigger a compiler crash :|

worked around the compiler crash.

@weissi weissi added the 🔨 semver/patch No public API change. label Jan 27, 2025
@weissi weissi enabled auto-merge (squash) January 27, 2025 23:12
@Lukasa
Copy link
Contributor

Lukasa commented Jan 28, 2025

@weissi The formatter wants you to remove -> Void from your function declaration. As you're working around a compiler crash, I don't want to just unilaterally make that change for you without you reproducing whether the compiler continues not to crash with this spelling.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants