testConnect() declared a custom Socket but never used it. #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the test failure is actually related to the same problem as @Lukasa stated here: #330 (comment) (as we also do register first and then call connect) |
Motivation: testConnect() should use its custom Socket implementation. Modifications: Make the test use the custom Socket Result: Correct test
normanmaurer
force-pushed
the
fix_test_connect
branch
from
3d8b99d to
115a558
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
testConnect() should use its custom Socket implementation.
Modifications:
Make the test use the custom Socket
Result:
Correct test