Ensure localAddress / remoteAddress are still accessible in channelIn… #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ldewailly PTAL as well |
Lukasa
requested changes
Apr 23, 2018
Sources/NIO/ChannelPipeline.swift
Outdated
| do { | ||
| // Fast-path access to the remoteAddress. | ||
| return try self.channel._unsafe.remoteAddress0() | ||
| } catch let err as ChannelError where err == .ioOnClosedChannel { |
There was a problem hiding this comment.
No need for this verbose syntax, just do catch ChannelError.ioOnClosedChannel.
Sources/NIO/ChannelPipeline.swift
Outdated
| do { | ||
| // Fast-path access to the localAddress. | ||
| return try self.channel._unsafe.localAddress0() | ||
| } catch let err as ChannelError where err == .ioOnClosedChannel { |
normanmaurer
force-pushed
the
local_remote_address_inactive
branch
2 times, most recently
from
8cf0ced to
f960e25
Compare
|
@Lukasa addressed |
…active / handlerRemoved Motivation: Often its useful to be still be able to access the local / remote address during channelInactive / handlerRemoved callbacks to for example log it. We should ensure its still accessible during it. Modifications: - Fallback to slow-path in ChannelHandlerContext.localAddress0 / remoteAddress0 if fast-path fails to try accessing the address via the cache. - Clear cached addresses after all callbacks are run. - Add unit test. Result: Be able to access addresses while handlers are notified.
normanmaurer
force-pushed
the
local_remote_address_inactive
branch
from
f960e25 to
d655f04
Compare
Lukasa
approved these changes
Apr 23, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…active / handlerRemoved
Motivation:
Often its useful to be still be able to access the local / remote address during channelInactive / handlerRemoved callbacks to for example log it. We should ensure its still accessible during it.
Modifications:
Result:
Be able to access addresses while handlers are notified.