-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add useful dtrace scripts to debug allocations #352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-nio-bot test this please |
the failure in 4.1 was
guess we can just retry that |
@swift-nio-bot test this please |
normanmaurer
approved these changes
Apr 25, 2018
@swift-nio-bot test this please |
Lukasa
requested changes
Apr 25, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit
dev/malloc-aggregation.d
Outdated
printf("This will collect stack shots of allocations and print it when "); | ||
printf("you exit dtrace.\n"); | ||
printf("So go ahead, run your tests and then press Ctrl+C in this window "); | ||
printf("to see the aggreated result\n"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: "aggregated"
def28f9
to
ffcd471
Compare
Motivation: dtrace is extrmely useful when debugging allocation related issues. This adds two scripts that have helped me many times. Modifications: - `dev/malloc-aggregation.d` which prints an aggregation of all stacks that have allocated - `dev/boxed-existentials.d` which live prints all allocations of boxed existentials Result: sharing debugging tools is great
ffcd471
to
f7b9acf
Compare
Lukasa
approved these changes
Apr 25, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
dtrace is extrmely useful when debugging allocation related issues. This
adds two scripts that have helped me many times.
Modifications:
dev/malloc-aggregation.d
which prints an aggregation of allstacks that have allocated
dev/boxed-existentials.d
which live prints all allocations of boxedexistentials
Result:
sharing debugging tools is great