Fix warning during compiling tests. #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-nio-bot test this please |
Lukasa
requested changes
Apr 26, 2018
Tests/NIOTests/SelectorTest.swift
Outdated
| @@ -358,7 +358,7 @@ class SelectorTest: XCTestCase { | |||
| return channel | |||
| } | |||
| } | |||
| }.wait().forEach { return try! $0.wait() } as Void) | |||
| }.wait().forEach { _ = try! $0.wait() } as Void) | |||
There was a problem hiding this comment.
Rather than just suppress the return value, why not wrap this in a XCTAssertNoThrow and remove the try!? That way we have .forEach { XCTAssertNoThrow(try $0.wait) }, which would be a bit better.
Motivation:
When compiling the tests the following warning is printed:
swift-nio/Tests/NIOTests/SelectorTest.swift:361:43: warning: result of call to 'wait()' is unused
}.wait().forEach { return try! $0.wait() } as Void)
Modifications:
Use XCTAssertNoThrow to silence the warnings.
Result:
No more warnings.
normanmaurer
force-pushed
the
fix_selector_test_warning
branch
from
b9598a6 to
077e4e3
Compare
|
@Lukasa addressed |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When compiling the tests the following warning is printed:
swift-nio/Tests/NIOTests/SelectorTest.swift:361:43: warning: result of call to 'wait()' is unused
}.wait().forEach { return try! $0.wait() } as Void)
Modifications:
Ignore return value to silent the compiler warnings.
Result:
No more warnings.