connect timeout tests: work around ECONNREFUSED #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Some network configurations might disallow connecting to unknown IP addresses. The effect of that is that we might see `ECONNREFUSED` when trying to connect to 198.51.100.254 which nominally is reserved for documentation only (ie. we shouldn't get any RSTs). Modifications: ignore `ECONNREFUSED` in the timeout tests too Result: tests stable in less permissive network environments
Lukasa
approved these changes
Nov 13, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some network configurations might disallow connecting to unknown IP
addresses. The effect of that is that we might see
ECONNREFUSEDwhentrying to connect to 198.51.100.254 which nominally is reserved for
documentation only (ie. we shouldn't get any RSTs).
Modifications:
ignore
ECONNREFUSEDin the timeout tests tooResult:
tests stable in less permissive network environments