ByteBuffer test: remove bogus test assertion #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: One ByteBuffer test was (for whatever reason) asserting that realloc never succeeds in realloc'ing from 16 to 32 bytes. That just failed on macOS, presumably an allocator change. Modifications: remove bogus assertion about reallocs ability to grow allocations. Result: tests more stable
Lukasa
approved these changes
Nov 15, 2018
normanmaurer
approved these changes
Nov 15, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
One ByteBuffer test was (for whatever reason) asserting that realloc
never succeeds in realloc'ing from 16 to 32 bytes. That just failed on
macOS, presumably an allocator change.
Modifications:
remove bogus assertion about reallocs ability to grow allocations.
Result:
tests more stable