Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Assign channel variable in docs #662

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Assign channel variable in docs #662

merged 1 commit into from
Nov 27, 2018

Conversation

Bouke
Copy link
Contributor

@Bouke Bouke commented Nov 26, 2018

Add missing variable assignment to make the code sample workable.

@swift-nio-bot
Copy link

Can one of the admins verify this patch?

2 similar comments
@swift-nio-bot
Copy link

Can one of the admins verify this patch?

@swift-nio-bot
Copy link

Can one of the admins verify this patch?

Lukasa
Lukasa approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@Lukasa Lukasa added the 🔨 semver/patch No public API change. label Nov 26, 2018
@Lukasa Lukasa added this to the 1.12.0 milestone Nov 26, 2018
@Lukasa
Copy link
Contributor

Lukasa commented Nov 26, 2018

@swift-nio-bot test this please

@Lukasa Lukasa merged commit 29398d5 into apple:master Nov 27, 2018
@weissi
Copy link
Member

weissi commented Nov 27, 2018

thanks @Bouke

@normanmaurer
Copy link
Member

@Bouke thanks :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Bouke @swift-nio-bot @Lukasa @weissi @normanmaurer