update contributors file #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Now, shortly before 2.0 is a good time to update the contributors list. Modifications: Ran the contributor generation script (ASCII'd my name) Result: All contributors get their proper credit.
Lukasa
reviewed
Nov 27, 2018
| @@ -1,7 +1,7 @@ | |||
| Tomer Doron <tomerd@apple.com> <tomer.doron@gmail.com> | |||
| Tomer Doron <tomerd@apple.com> | |||
| Max Moiseev <moiseev@apple.com> | |||
| Johannes Weiß <johannesweiss@apple.com> | |||
| Johannes Weiss <johannesweiss@apple.com> Johannes Weiß <johannesweiss@apple.com> | |||
There was a problem hiding this comment.
This change brought to you by HM Government.
Lukasa
approved these changes
Nov 27, 2018
|
Why ASCII your name when we just got efficient UTF-8 strings? |
stuff breaks, such as git's |
|
Doesn't that imply you have to ASCII me as well? |
|
@helje5 so far we didn't |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Now, shortly before 2.0 is a good time to update the contributors list.
Modifications:
Ran the contributor generation script (ASCII'd my name)
Result:
All contributors get their proper credit.