[nio-1.13] Make NIOAny log the contents of its storage when encountering fatal unwrapping errors.
#879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unwrapping errors. Motivation: This should make debugging crashes easier, as knowing the contents of the badly-unwrapped `NIOAny` should make it more clear where exactly it could have been written. Personally I'd prefer this to never cause a fatal error, but I assume that would need more discussion.
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
Lukasa
approved these changes
Mar 6, 2019
|
@swift-nio-bot test this please |
|
@swift-nio-ci add to whitelist |
|
@swift-nio-bot test this please |
weissi
approved these changes
Mar 6, 2019
|
Spurious failure, let’s test again. |
|
@swift-nio-bot test this please |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
NIOAnylog the contents of its storage when encountering fatal unwrapping errors.Motivation:
This should make debugging crashes easier, as knowing the contents of the badly-unwrapped
NIOAnyshould make it more clear where exactly it could have been written. Personally I'd prefer this to never cause a fatal error, but I assume that would need more discussion.Modifications:
See above.
Result:
Fatal errors caused by unwrapping
NIOAnywill show the actual contents of the badly-unwrappedNIOAnyobject, not just its type.