Simplify Heap implementation. #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Lukasa would you mind checking if the allocations went down, I'd expect them to for the connection tests :) |
Lukasa
force-pushed
the
cb-rewrite-heap
branch
3 times, most recently
from
931e163 to
e898ddd
Compare
Motivation: Our original Heap implementation used a bunch of static functions in order to make it clear how it related to textbook heap implementations. This was primarily done to ensure that it was easier to see the correctness of the code. However, we've long been satisfied with the correctness of the code, and the Heap is one of the best tested parts of NIO. For this reason, we should be free to refactor it. Given https://bugs.swift.org/browse/SR-10346, we've been given an incentive to do that refactor right now. This is because the Heap is causing repeated CoW operations each time we enqueue new work onto the event loop. That's a substantial performance cost: well worth fixing with a small rewrite. Modifications: - Removed all static funcs from Heap - Rewrote some into instance funcs - Merged the implementation of insert into append. - Added an allocation test to avoid regressing this change. Result: Faster Heap, happier users, sadder textbook authors.
weissi
pushed a commit
that referenced
this pull request
Apr 12, 2019
Motivation: Our original Heap implementation used a bunch of static functions in order to make it clear how it related to textbook heap implementations. This was primarily done to ensure that it was easier to see the correctness of the code. However, we've long been satisfied with the correctness of the code, and the Heap is one of the best tested parts of NIO. For this reason, we should be free to refactor it. Given https://bugs.swift.org/browse/SR-10346, we've been given an incentive to do that refactor right now. This is because the Heap is causing repeated CoW operations each time we enqueue new work onto the event loop. That's a substantial performance cost: well worth fixing with a small rewrite. Modifications: - Removed all static funcs from Heap - Rewrote some into instance funcs - Merged the implementation of insert into append. - Added an allocation test to avoid regressing this change. Result: Faster Heap, happier users, sadder textbook authors. (cherry picked from commit 0179535)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Our original Heap implementation used a bunch of static functions
in order to make it clear how it related to textbook heap
implementations. This was primarily done to ensure that it was easier
to see the correctness of the code.
However, we've long been satisfied with the correctness of the code,
and the Heap is one of the best tested parts of NIO. For this reason,
we should be free to refactor it.
Given https://bugs.swift.org/browse/SR-10346, we've been given an
incentive to do that refactor right now. This is because the Heap
is causing repeated CoW operations each time we enqueue new work
onto the event loop. That's a substantial performance cost: well
worth fixing with a small rewrite.
Modifications:
Result:
Faster Heap, happier users, sadder textbook authors.