Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add Swift 5.1 docker file #991

Merged
merged 2 commits into from
May 2, 2019
Merged

add Swift 5.1 docker file #991

merged 2 commits into from
May 2, 2019

Conversation

weissi
Copy link
Member

@weissi weissi commented May 2, 2019

Motivation:

We should test all available Swift versions, including snapshots.

Modifications:

Add docker compose file for Swift 5.1.

Result:

More testing.

Motivation:

We should test all available Swift versions, including snapshots.

Modifications:

Add docker compose file for Swift 5.1.

Result:

More testing.
@weissi weissi requested a review from Lukasa May 2, 2019 11:34
@Lukasa Lukasa added the 🔨 semver/patch No public API change. label May 2, 2019
@Lukasa Lukasa added this to the 2.1.0 milestone May 2, 2019
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this using Ubuntu 16.04?

@weissi
Copy link
Member Author

weissi commented May 2, 2019

Why is this using Ubuntu 16.04?

Just to cover more of the OS / Swift version matrix. 5.0 tests on 18.04, so I made 5.1 test on 16.04.

Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@Lukasa Lukasa merged commit ba3733a into apple:master May 2, 2019
@weissi weissi deleted the jw-swift-5.1 branch May 2, 2019 14:08
image: swift-nio:16.04-5.1
build:
args:
ubuntu_version: "16.04"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not 18.04?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, great minds!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants