Update the proto files from upstream. #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allevato
approved these changes
Jan 8, 2024
|
protoc is doing something I didn't expect here. it seems the files labeled with editions are still getting through the generator even though we don't support editions. |
Using 991a2f4d54c6944396f55eaf13ae5248598ed28a from protobuf. Leaving off the file have been converted over to editions.
thomasvl
force-pushed
the
update_upstream_protos
branch
from
9062552 to
1637f60
Compare
|
Updated commits to not update the files that have moved to editions, reached out to the protobuf team to check on the behavior change I'm seeing. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.