Conditional foundation import #1704
Merged
+35
−146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gjcairo fyi |
allevato
approved these changes
Aug 28, 2024
gjcairo
reviewed
Aug 29, 2024
| @@ -15,6 +15,22 @@ extension FileDescriptor { | |||
| return SwiftProtobufInfo.isBundledProto(file: self) | |||
| } | |||
|
|
|||
| // Returns true if the file will beed to import Foundation. | |||
There was a problem hiding this comment.
Suggested change
| // Returns true if the file will beed to import Foundation. | |
| // Returns true if the file will need to import Foundation. |
| @@ -166,6 +182,22 @@ extension Descriptor { | |||
| /// Returns true if the message should use the message set wireformat. | |||
| var useMessageSetWireFormat: Bool { return options.messageSetWireFormat } | |||
|
|
|||
| var needsFoundationImport: Bool { | |||
There was a problem hiding this comment.
Nit: can we add the same docs from FileDescriptor above to this?
|
Oops, window didn't reload to show the comment until after I hit merge. Follow up PR coming. |
thomasvl
added a commit
to thomasvl/swift-protobuf
that referenced
this pull request
Aug 29, 2024
thomasvl
added a commit
to thomasvl/swift-protobuf
that referenced
this pull request
Aug 29, 2024
thomasvl
added a commit
that referenced
this pull request
Aug 29, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.