Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add visionos to podspec #1752

Merged
merged 2 commits into from
Feb 4, 2025
Merged

add visionos to podspec #1752

merged 2 commits into from
Feb 4, 2025

Conversation

grachyov
Copy link
Contributor

@grachyov grachyov commented Feb 2, 2025

No description provided.

@thomasvl thomasvl requested a review from tbkka February 4, 2025 14:30
@tbkka
Copy link
Collaborator

tbkka commented Feb 4, 2025

@FranzBusch I'm not sure how to read the semantic version label check failure here?

@thomasvl
Copy link
Collaborator

thomasvl commented Feb 4, 2025

@FranzBusch I'm not sure how to read the semantic version label check failure here?

I think we just have to add the label.

@thomasvl thomasvl added the semver/none No version bump required. label Feb 4, 2025
@thomasvl
Copy link
Collaborator

thomasvl commented Feb 4, 2025

I'll try to look at the upstream protobuf build issues later, but I'm have a non-normal week this week, so not sure when I'll get to look.

@thomasvl
Copy link
Collaborator

thomasvl commented Feb 4, 2025

I'll try to look at the upstream protobuf build issues later, but I'm have a non-normal week this week, so not sure when I'll get to look.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90415
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=14597b680a24b6f7375e4470dea935da9c369feb

Appears to be a compiler bug. I've let the protobuf team upstream know, hopefully they can tweak their sources to avoid this since it will be an issue for their customers on older (but supported) versions.

@thomasvl
Copy link
Collaborator

thomasvl commented Feb 4, 2025

Merging since this podspec won't have anything to do with the failures.

Thanks for the patch!

@thomasvl thomasvl merged commit f79accc into apple:main Feb 4, 2025
11 of 14 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants