Skip to content
This repository was archived by the owner on Oct 19, 2023. It is now read-only.

error thrown for non-existing element #138

Open
wants to merge 1 commit into
base: universal-sdk
Choose a base branch
from

Conversation

chaim-aharonson-applitools
Copy link
Collaborator

Also added support for non-js-languages, not sure how to verify it works there as well

Copy link

@tourdedave tourdedave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with the emitting code these days. But at a glance it looks good. For the other languages, it probably makes to tag one or more developers from the other SDK team for them to review. That, or Artem from the QA team.

@chaim-aharonson-applitools
Copy link
Collaborator Author

I'm not too familiar with the emitting code these days. But at a glance it looks good. For the other languages, it probably makes to tag one or more developers from the other SDK team for them to review. That, or Artem from the QA team.

@amitzur , following @tourdedave comment, should I add the test to overrides.js (for other frameworks) and by that will avoid tests failures and signal the other SDK team that it needs to be checked? in case I shouldn't add to overrides.js - should I mention Artem here?

Copy link
Member

@amitzur amitzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See one inline comment. I believe that even with my suggestion, the emitters for non-JS will have work to do to make this work. So skip it in overrides and tag Artem for help.

() => void eyes.check({
region: '.non-existing-element',
}),
error => helpers.hasErrorMessage(error, 'Element not found!')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you could do:

error => assert.equal(error.message, 'Element not found!')

And avoid the need to add hasErrorMessage.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants