Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix send-to-zfs crash when VM has a detached CDROM #19

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

lowell80
Copy link
Contributor

@lowell80 lowell80 commented Nov 7, 2024

  • Silently skip storage volume path of 'none'

Example of a problematic config:

root@proxmox-node01:~# qm config 104 | grep ide
boot: order=virtio0;ide2;net0
ide2: none,media=cdrom

This would run the command pvesm path none which would produce the output:

400 Parameter verification failed.
volume: invalid format - unable to parse volume ID 'none'

Simply skipping "none" devices should prevent this. While looking for media=cdrom may also work, this seemed like the most direct approach without having to remember to add backup=0 to all VMs.

- Silently skip storage volume path of 'none'
@apprell apprell merged commit 666e846 into apprell:master Nov 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants