Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Node 12.0 support #2921

Closed
nschonni opened this issue Apr 24, 2019 · 7 comments
Closed

Node 12.0 support #2921

nschonni opened this issue Apr 24, 2019 · 7 comments

Comments

@nschonni
Copy link

Node 12.0 was released today https://nodejs.org/en/blog/release/v12.0.0/

@shiftkey
Copy link

As a workaround, there is a documented method to use whatever versions of Node you want. This helped me upgrade a couple of projects earlier in the week:

https://github.com/atom/fs-admin/blob/master/appveyor.yml

environment:
  matrix:
  - nodejs_version: "8"
  - nodejs_version: "10"
  - nodejs_version: "11"
  - nodejs_version: "12"

platform:
  - x86
  - x64

install:
  # https://www.appveyor.com/docs/lang/nodejs-iojs/#installing-any-version-of-nodejs-or-iojs
  - ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) $env:PLATFORM
  - npm install

@IlyaFinkelshteyn IlyaFinkelshteyn added this to the next-images-update milestone Apr 25, 2019
@nschonni
Copy link
Author

Thanks @shiftkey the workaround did work. I'll leave this open till the images get updated though

@IlyaFinkelshteyn
Copy link
Contributor

@nschonni yes, please do not close :)

ahwayakchih added a commit to ahwayakchih/native-hdr-histogram that referenced this issue May 14, 2019
Try to use workaround for missing "default" Node v12 on appveyor:
appveyor/ci#2921 (comment)
willmorgan added a commit to tediousjs/node-mssql that referenced this issue May 18, 2019
willmorgan added a commit to tediousjs/node-mssql that referenced this issue May 18, 2019
addaleax pushed a commit to addaleax/lzma-native that referenced this issue May 23, 2019
* Update code to compile with Node 12 as well
* Add Node 12 tests for appveyor and Travis
* Update how to pull Node packages for appveyor

Based on  appveyor/ci#2921 (comment)

Signed-off-by: Gergely Imreh <gergely@balena.io>
PR-URL: #81
MadLittleMods pushed a commit to MadLittleMods/node-usb-detection that referenced this issue May 27, 2019
We aren't using Node 12 from AppVeyor as it is not supported yet, appveyor/ci#2921
dhritzkiv added a commit to stackgl/headless-gl that referenced this issue May 29, 2019
Node 12 may not be pre-built yet? appveyor/ci#2921
ybiquitous added a commit to stylelint/stylelint that referenced this issue May 31, 2019
hudochenkov pushed a commit to stylelint/stylelint that referenced this issue May 31, 2019
@plroebuck
Copy link

@lyaFinkelshteyn, is there a PS way to essentially do this in the install step?

try {
  Install-Product node $env:nodejs_version $env:platform
} catch(err) {
  Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) $env:platform
} 

As Node-12 is still unavailable, Update-NodeJsInstallation is the only way to get it.
But since we also test against available versions, being unable to use Install-Product for them just adds further delay.

environment:
  matrix:
    - nodejs_version: '12'
    - nodejs_version: '10'
    - nodejs_version: '8'
    - nodejs_version: '6'

@plroebuck
Copy link

@IlyaFinkelshteyn ping!

@IlyaFinkelshteyn
Copy link
Contributor

Node.JS 12 is available on AppVeyor environment!

@IlyaFinkelshteyn
Copy link
Contributor

IlyaFinkelshteyn commented Jun 11, 2019

@plroebuck sorry, missed your message. This YAML would work for you (though you do not need it now, but may help later):

environment:
  matrix:
    - nodejs_version: '12'
    - nodejs_version: '10'
    - nodejs_version: '8'
    - nodejs_version: '6'

platform:
  - x86
  - x64

install:
  - ps: |
      try {
      Install-Product node $env:nodejs_version $env:platform
      } catch {
      echo "Unable to install node $env:nodejs_version, trying update..."
      Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) $env:platform
      }

shinnn added a commit to shinnn/coverage that referenced this issue Jun 26, 2019
luislobo added a commit to luislobo/sails-mongo that referenced this issue Jul 5, 2019
dhensby pushed a commit to tediousjs/node-mssql that referenced this issue Aug 2, 2019
waitingsong added a commit to waitingsong/kmore that referenced this issue Sep 8, 2019
waitingsong added a commit to waitingsong/kmore that referenced this issue Sep 8, 2019
waitingsong added a commit to waitingsong/kmore that referenced this issue Sep 9, 2019
waitingsong added a commit to waitingsong/kmore that referenced this issue Sep 9, 2019
PresentKim added a commit to PresentKim/_pages_hexo that referenced this issue Sep 20, 2019
dhensby pushed a commit to tediousjs/node-mssql that referenced this issue Nov 5, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants