Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix infinite loading of quickstart templates #527

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Sep 1, 2023

What does this PR do?

This happens when Appwrite deosn't have the runtime from the quickstart template enabled. This change:

  1. filters the quickstart templates to only include enabled runtimes
  2. only shows the "more" template card if there were more than 5 filtered templates

Test Plan

With:

_APP_FUNCTIONS_RUNTIMES=node-16.0,php-8.0,python-3.9,ruby-3.0,java-16.0

image

With:

_APP_FUNCTIONS_RUNTIMES=

image

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 3:11pm
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 3:11pm
console-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 3:11pm

This happens when Appwrite deosn't have the runtime from the quickstart
template enabled. This change filters the quickstart templates to only
include enabled runtimes.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: "Quick Start" Infinite loadings when creating a function
3 participants