Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix apple xpc interrupt #717

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Fix apple xpc interrupt #717

merged 2 commits into from
Sep 13, 2023

Conversation

abnegate
Copy link
Member

What does this PR do?

  • Fix XPC connection interrupted when app in background during OAuth login for Apple

Test Plan

Manual test

Related PRs and Issues

appwrite/appwrite#6206

Have you read the Contributing Guidelines on issues?

Yes

@ItzNotABug
Copy link
Member

I don't think this would fix the:
Accessing Environment<OpenURLAction>'s value outside of being installed on a View. This will always read the default value and will not update warning.

It may not be something major, its just pretty annoying.

@abnegate
Copy link
Member Author

I don't think this would fix the: Accessing Environment<OpenURLAction>'s value outside of being installed on a View. This will always read the default value and will not update warning.

It may not be something major, its just pretty annoying.

@ItzNotABug Correct, it won't fix that warning - we'll address that one separately in future 👍

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know Swift and I didn't generate the SDK to confirm things, but the template syntax looks okay.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants