Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

added indexed categorical layer evaluation #313

Merged
merged 2 commits into from
Nov 8, 2024
Merged

added indexed categorical layer evaluation #313

merged 2 commits into from
Nov 8, 2024

Conversation

gengala
Copy link
Collaborator

@gengala gengala commented Nov 5, 2024

as per title.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.18%. Comparing base (fee7960) to head (fe1d8a6).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
cirkit/backend/torch/layers/input.py 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
- Coverage   68.26%   68.18%   -0.09%     
==========================================
  Files          51       51              
  Lines        5360     5368       +8     
  Branches      613      616       +3     
==========================================
+ Hits         3659     3660       +1     
- Misses       1486     1492       +6     
- Partials      215      216       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loreloc
Copy link
Member

loreloc commented Nov 7, 2024

Thank you! Please run the automatic formatter black (see the instructions in README.md). Also, better to avoid unnecessary logic in inference methods. You can cache the result of the if len(torch.unique(self.scope_idx)) > 4096 or self.num_categories > 256 in a boolean value in the init method.

@loreloc loreloc merged commit 3e51b42 into main Nov 8, 2024
1 of 4 checks passed
@loreloc loreloc deleted the idx-cat-layer branch November 8, 2024 10:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants