Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[move-examples] Add multiple examples for resource accounts #8621

Closed
wants to merge 10 commits into from

Conversation

xbtmatt
Copy link
Contributor

@xbtmatt xbtmatt commented Jun 12, 2023

Description

Merged the publishing code from this module with the package manager in PR #8641.

Added three sections to the examples/resource-accounts section in the docs.

The tutorial shows examples and sample code that you can compile and publish to test it.

Test Plan

There is a unit test in upgradeable_resource_account_package.rs in the unit tests folder:

RUST_MIN_STACK=4297152 cargo test --package e2e-move-tests --lib -- tests::upgradeable_resource_account_package::code_upgrading_using_resource_account --exact --nocapture

The tutorial shows a more complete example of how to do it using the build-publish-package command to generate a JSON file with the module bytecode.

Copy link
Contributor

@davidiw davidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we merge this pr #8641 (review) here?

@movekevin

Copy link
Contributor

@davidiw davidiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes so I don't open this again until it is ready, feel free to dismiss or poke me for a review

@sionescu sionescu requested a review from a team as a code owner July 18, 2023 17:17
@xbtmatt xbtmatt force-pushed the matt/resource_accounts branch 2 times, most recently from f28e813 to 4ef84a2 Compare July 20, 2023 06:41
@xbtmatt xbtmatt force-pushed the matt/resource_accounts branch 3 times, most recently from 451263c to 8a425a8 Compare July 25, 2023 01:34
xbtmatt added 8 commits July 24, 2023 18:52
…to use a resource account. Added an example in move-examples and a unit test for it for publishing an upgradeable module.
…e contract. Updated the tutorial to show how to use it. The tutorial shows how to use the newly added `build-publish-package` function to get the bytecode in a JSON file and run the upgrade_contract function with it.
…move and resource_account.move, and moved the structure around. Also added auth key rotation examples from #9130 to refer to.
…ugh revising everything. Still need to add kevin's package manager and explanation into the tutorial.
… explanation of it and features, and separating the guide into 3 sections. Updated unit test.
@xbtmatt xbtmatt force-pushed the matt/resource_accounts branch from 8a425a8 to e50b5ee Compare July 25, 2023 01:54
@xbtmatt xbtmatt requested a review from davidiw July 25, 2023 02:02
@xbtmatt
Copy link
Contributor Author

xbtmatt commented Jul 25, 2023

@saharct Wasn't sure how to structure the subsections, there's a lot of content in there. I also feel some of it could go in a different section, but tried to organize it so it's all together. Tagging you in case you want to check it

…of analogous real world use case, and explanation of seed
@xbtmatt xbtmatt requested a review from 0xmaayan July 27, 2023 06:48
@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants