Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Faucet][CLI] Add message to indicate faucet is starting #8842

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

banool
Copy link
Contributor

@banool banool commented Jun 26, 2023

Description

Small quality of life improvement. This way users can tell that the faucet hasn't actually started yet.

Test Plan

$ cargo run -p aptos -- node run-local-testnet --force-restart --with-faucet --assume-yes
Completed generating configuration:
        Log file: "/Users/dport/.aptos/testnet/validator.log"
        Test dir: "/Users/dport/.aptos/testnet"
        Aptos root key path: "/Users/dport/.aptos/testnet/mint.key"
        Waypoint: 0:645b3a18445fbb7ae17031b2e5f14929bfbf8d5612acdd668be2a6824c31ea0d
        ChainId: testing
        REST API endpoint: http://0.0.0.0:8080
        Metrics endpoint: http://0.0.0.0:9101/metrics
        Aptosnet fullnode network endpoint: /ip4/0.0.0.0/tcp/6181

Aptos is running, press ctrl-c to exit

Faucet is starting, please wait...
Faucet is running. Faucet endpoint: http://0.0.0.0:8081

@banool banool requested a review from gregnazario as a code owner June 26, 2023 11:18
@banool banool force-pushed the banool/starting-faucet-message branch from b4f6f70 to 54975f8 Compare June 26, 2023 11:31
@banool banool requested a review from 0xmigo June 26, 2023 11:31
@banool banool enabled auto-merge (squash) June 26, 2023 11:31
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

✅ Forge suite compat success on aptos-node-v1.4.4 ==> 54975f86d58a7ac108dc7a3d6ba22147ad111e9e

Compatibility test results for aptos-node-v1.4.4 ==> 54975f86d58a7ac108dc7a3d6ba22147ad111e9e (PR)
1. Check liveness of validators at old version: aptos-node-v1.4.4
compatibility::simple-validator-upgrade::liveness-check : committed: 6667 txn/s, latency: 4838 ms, (p50: 4800 ms, p90: 7000 ms, p99: 8100 ms), latency samples: 233360
2. Upgrading first Validator to new version: 54975f86d58a7ac108dc7a3d6ba22147ad111e9e
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 3639 txn/s, latency: 8495 ms, (p50: 9500 ms, p90: 10800 ms, p99: 11500 ms), latency samples: 145560
3. Upgrading rest of first batch to new version: 54975f86d58a7ac108dc7a3d6ba22147ad111e9e
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4094 txn/s, latency: 7622 ms, (p50: 7900 ms, p90: 9600 ms, p99: 10600 ms), latency samples: 163760
4. upgrading second batch to new version: 54975f86d58a7ac108dc7a3d6ba22147ad111e9e
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6561 txn/s, latency: 5011 ms, (p50: 5000 ms, p90: 7200 ms, p99: 8700 ms), latency samples: 236220
5. check swarm health
Compatibility test for aptos-node-v1.4.4 ==> 54975f86d58a7ac108dc7a3d6ba22147ad111e9e passed
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite land_blocking success on 54975f86d58a7ac108dc7a3d6ba22147ad111e9e

performance benchmark : committed: 5478 txn/s, latency: 7256 ms, (p50: 6600 ms, p90: 9900 ms, p99: 20100 ms), latency samples: 2339519
Max round gap was 2 [limit 4] at version 2387896. Max no progress secs was 4.575823 [limit 10] at version 2387896.
Test Ok

@github-actions
Copy link
Contributor

✅ Forge suite framework_upgrade success on aptos-node-v1.4.4 ==> 54975f86d58a7ac108dc7a3d6ba22147ad111e9e

Compatibility test results for aptos-node-v1.4.4 ==> 54975f86d58a7ac108dc7a3d6ba22147ad111e9e (PR)
Upgrade the nodes to version: 54975f86d58a7ac108dc7a3d6ba22147ad111e9e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4563 txn/s, latency: 6982 ms, (p50: 6300 ms, p90: 10500 ms, p99: 21500 ms), latency samples: 177980
5. check swarm health
Compatibility test for aptos-node-v1.4.4 ==> 54975f86d58a7ac108dc7a3d6ba22147ad111e9e passed
Test Ok

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants