Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BlockSTM] Counter Fix #8933

Merged
merged 5 commits into from
Jul 4, 2023
Merged

[BlockSTM] Counter Fix #8933

merged 5 commits into from
Jul 4, 2023

Conversation

danielxiangzl
Copy link
Contributor

Description

Update txn gas counter when BlockSTM finishes without falling back to sequential execution to avoid double counting. Also fix one typo in sequential execution counter.

Test Plan

@danielxiangzl danielxiangzl enabled auto-merge (squash) July 3, 2023 19:40
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@igor-aptos igor-aptos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single_node_preformance results look good (fixed)!

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

✅ Forge suite compat success on aptos-node-v1.4.4 ==> b9bcffd34930afa7ed96dd3c50275ac775f48d7e

Compatibility test results for aptos-node-v1.4.4 ==> b9bcffd34930afa7ed96dd3c50275ac775f48d7e (PR)
1. Check liveness of validators at old version: aptos-node-v1.4.4
compatibility::simple-validator-upgrade::liveness-check : committed: 6912 txn/s, latency: 4750 ms, (p50: 4700 ms, p90: 5800 ms, p99: 7700 ms), latency samples: 241940
2. Upgrading first Validator to new version: b9bcffd34930afa7ed96dd3c50275ac775f48d7e
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4568 txn/s, latency: 6899 ms, (p50: 7700 ms, p90: 9000 ms, p99: 9400 ms), latency samples: 173620
3. Upgrading rest of first batch to new version: b9bcffd34930afa7ed96dd3c50275ac775f48d7e
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4110 txn/s, latency: 7668 ms, (p50: 8200 ms, p90: 9200 ms, p99: 9800 ms), latency samples: 156180
4. upgrading second batch to new version: b9bcffd34930afa7ed96dd3c50275ac775f48d7e
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 6396 txn/s, latency: 5122 ms, (p50: 4900 ms, p90: 7500 ms, p99: 9400 ms), latency samples: 230260
5. check swarm health
Compatibility test for aptos-node-v1.4.4 ==> b9bcffd34930afa7ed96dd3c50275ac775f48d7e passed
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

✅ Forge suite realistic_env_max_load success on b9bcffd34930afa7ed96dd3c50275ac775f48d7e

two traffics test: inner traffic : committed: 5790 txn/s, latency: 6742 ms, (p50: 6400 ms, p90: 8100 ms, p99: 15200 ms), latency samples: 2513040
two traffics test : committed: 100 txn/s, latency: 2595 ms, (p50: 2500 ms, p90: 3100 ms, p99: 7000 ms), latency samples: 1840
Max round gap was 1 [limit 4] at version 654812. Max no progress secs was 3.736304 [limit 10] at version 654812.
Test Ok

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

✅ Forge suite framework_upgrade success on aptos-node-v1.4.4 ==> b9bcffd34930afa7ed96dd3c50275ac775f48d7e

Compatibility test results for aptos-node-v1.4.4 ==> b9bcffd34930afa7ed96dd3c50275ac775f48d7e (PR)
Upgrade the nodes to version: b9bcffd34930afa7ed96dd3c50275ac775f48d7e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 4714 txn/s, latency: 6896 ms, (p50: 6500 ms, p90: 10500 ms, p99: 17400 ms), latency samples: 174420
5. check swarm health
Compatibility test for aptos-node-v1.4.4 ==> b9bcffd34930afa7ed96dd3c50275ac775f48d7e passed
Test Ok

@danielxiangzl danielxiangzl merged commit f022126 into main Jul 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants