address feedback

aptos-labs · Apr 29, 2024 · c8bde46 · c8bde46
1 parent bb530e3
commit c8bde46
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/apps/nextjs-example/components/AlertProvider.tsx b/apps/nextjs-example/components/AlertProvider.tsx
@@ -38,7 +38,7 @@ export const AlertProvider: FC<{ children: ReactNode }> = ({ children }) => {
   const setSuccessAlertHash = useCallback(
     (hash: string, network: NetworkInfo | null) => {
       if (isAptosNetwork(network)) {
-        const explorerLink = `https://explorer.aptoslabs.com/txn/${hash}${network?.name ? `?network=${network.name.toLowerCase()}` : ""}`;
+        const explorerLink = `https://explorer.aptoslabs.com/txn/${hash}${network?.name ? `?network=${network.name}` : ""}`;
         return setSuccessAlertMessage(
           <>
             View on Explorer:{" "}

diff --git a/apps/nextjs-example/pages/index.tsx b/apps/nextjs-example/pages/index.tsx
@@ -32,12 +32,12 @@ const WalletSelectorAntDesign = dynamic(
   }
 );
 
-const isSendableNetwork = (connected: boolean, network?: string): boolean => {
-  return connected && !isMainnet(connected, network);
+const isSendableNetwork = (connected: boolean): boolean => {
+  return connected && !isMainnet(connected);
 };
 
-const isMainnet = (connected: boolean, network?: string): boolean => {
-  return connected && network?.toLowerCase() === Network.MAINNET.toLowerCase();
+const isMainnet = (connected: boolean, networkName?: string): boolean => {
+  return connected && networkName === Network.MAINNET;
 };
 
 export default function App() {

diff --git a/apps/nextjs-example/utils/index.ts b/apps/nextjs-example/utils/index.ts
@@ -2,11 +2,11 @@ import { Aptos, AptosConfig, Network } from "@aptos-labs/ts-sdk";
 import { NetworkInfo } from "@aptos-labs/wallet-adapter-core";
 
 export const aptosClient = (network?: NetworkInfo | null) => {
-  if (network?.name.toLowerCase() === Network.DEVNET.toLowerCase()) {
+  if (network?.name === Network.DEVNET) {
     return DEVNET_CLIENT;
-  } else if (network?.name.toLowerCase() === Network.TESTNET.toLowerCase()) {
+  } else if (network?.name === Network.TESTNET) {
     return TESTNET_CLIENT;
-  } else if (network?.name.toLowerCase() === Network.MAINNET.toLowerCase()) {
+  } else if (network?.name === Network.MAINNET) {
     throw new Error("Please use devnet or testnet for testing");
   } else {
     const CUSTOM_CONFIG = new AptosConfig({

diff --git a/packages/wallet-adapter-core/src/LegacyWalletPlugins/conversion.ts b/packages/wallet-adapter-core/src/LegacyWalletPlugins/conversion.ts
@@ -12,7 +12,7 @@ import { NetworkInfo } from "./types";
 export function convertNetwork(
   networkInfo: NetworkInfo | StandardNetworkInfo | null
 ): Network {
-  switch (networkInfo?.name.toLowerCase()) {
+  switch (networkInfo?.name) {
     case "mainnet" as Network:
       return Network.MAINNET;
     case "testnet" as Network:

diff --git a/packages/wallet-adapter-core/src/utils/helpers.ts b/packages/wallet-adapter-core/src/utils/helpers.ts
@@ -94,5 +94,5 @@ export const isAptosNetwork = (
   if (!networkInfo) {
     throw new Error("Undefined network");
   }
-  return NetworkToNodeAPI[networkInfo.name] ? true : false;
+  return NetworkToNodeAPI[networkInfo.name] !== undefined;
 };