Skip to content

Commit

Permalink
Temporarily silence a Rust error
Browse files Browse the repository at this point in the history
The generated Rust code from our proto files triggers a warning in Rust
nightly, which we treat as an error:

    error: custom inner attributes are unstable
    Error:  --> src/../proto/metadata.rs:9:4
      |
    9 | #![rustfmt::skip]
      |    ^^^^^^^^^^^^^
      |
      = note: `#[deny(soft_unstable)]` on by default
      = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
      = note: for more information, see issue #64266 <rust-lang/rust#64266>

This is already reported in the `rust-protobuf` repo [1] so until it's
fixed, we choose to silence this warning to make our builds work.

[1]: stepancheg/rust-protobuf#551
  • Loading branch information
apyrgio committed Mar 17, 2021
1 parent bcd03db commit 3886704
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,16 @@ Versioning].

## [Unreleased]

### Fixed

- Temporarily fix a build error for nightly Rust. In a nutshell, the generated
Rust code for our proto files triggers a compiler warning in nightly Rust,
which we ultimately treat as an error. Until this is fixed upstream, we
silence this warning. See also:

* https://github.com/stepancheg/rust-protobuf/issues/551
* https://github.com/rust-lang/rust/issues/64266

## [0.3.0] - 2021-01-11

### Added
Expand Down
3 changes: 3 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@
unused_results,
variant_size_differences
)]
// FIXME: This must be removed once this is solved:
// https://github.com/stepancheg/rust-protobuf/issues/551
#![allow(soft_unstable)]

pub mod aead;
pub mod cryptors;
Expand Down

0 comments on commit 3886704

Please # to comment.