fix grep string for check 1.4.11 and 1.4.12 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check 1.4.11 and 1.4.22 FAIL even when permissions is correct.
lizrice
suggested changes
Jun 7, 2018
cfg/1.8/master.yaml
Outdated
| tests: | ||
| test_items: | ||
| audit: ps -ef | grep $etcdbin | grep -- --data-dir | grep -v grep | sed 's%.*data-dir[= ]\([^ ]*\).*%\1%' | xargs stat -c %a | ||
| test_items: |
There was a problem hiding this comment.
Looks like this is missing tests:?
cfg/1.8/master.yaml
Outdated
| audit: ps -ef | grep $etcdbin | grep -v grep | sed 's%.*data-dir[= ]\([^ ]*\).*%\1%' | xargs stat -c %a | ||
| tests: | ||
| test_items: | ||
| audit: ps -ef | grep $etcdbin | grep -- --data-dir | grep -v grep | sed 's%.*data-dir[= ]\([^ ]*\).*%\1%' | xargs stat -c %a |
There was a problem hiding this comment.
I don't think there is any need for the grep -v grep step now that we are checking for --data-dir
cfg/1.8/master.yaml
Outdated
| @@ -960,7 +959,7 @@ groups: | |||
|
|
|||
| - id: 1.4.12 | |||
| text: "Ensure that the etcd data directory ownership is set to etcd:etcd (Scored)" | |||
| audit: ps -ef | grep $etcdbin | grep -v grep | sed 's%.*data-dir[= ]\(\S*\)%\1%' | xargs stat -c %U:%G | |||
| audit: ps -ef | grep $etcdbin | grep -- --data-dir | grep -v grep | sed 's%.*data-dir[= ]\(\S*\)%\1%' | xargs stat -c %U:%G | |||
There was a problem hiding this comment.
I think grep -v grep is now unnecessary here too
added tests: for 1.4.11 and removed grep -v grep for both
hutr
changed the title
|
Thanks for the correction. Added tests: for 1.4.11 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check 1.4.11 and 1.4.22 shows FAIL even when permissions is correct.