Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(ci): add missed args for building docker images #1788

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

afdesk
Copy link
Collaborator

@afdesk afdesk commented Jan 21, 2025

in #1781 there were missed args in result images for labels in Dockerfiles.
this PR adds args for alpine based images.

$ make build-docker
$ docker inspect aquasec/kube-bench:5557601 | grep label

Before:

                "org.label-schema.build-date": "2025-01-21T06:29:34Z",
                "org.label-schema.description": "Run the CIS Kubernetes Benchmark tests",
                "org.label-schema.maintainer": "admin@aquasec.com",
                "org.label-schema.name": "kube-bench",
                "org.label-schema.release": "",
                "org.label-schema.schema-version": "1.0",
                "org.label-schema.summary": "Aqua security server",
                "org.label-schema.url": "https://github.com/aquasecurity/kube-bench",
                "org.label-schema.vcs-ref": "5557601",
                "org.label-schema.vcs-url": "https://github.com/aquasecurity/kube-bench",
                "org.label-schema.vendor": "Aqua Security Software Ltd.",
                "org.label-schema.version": ""

After:

                "org.label-schema.build-date": "2025-01-21T06:49:46Z",
                "org.label-schema.description": "Run the CIS Kubernetes Benchmark tests",
                "org.label-schema.maintainer": "admin@aquasec.com",
                "org.label-schema.name": "kube-bench",
                "org.label-schema.release": "v0.10.0",
                "org.label-schema.schema-version": "1.0",
                "org.label-schema.summary": "Aqua security server",
                "org.label-schema.url": "https://github.com/aquasecurity/kube-bench",
                "org.label-schema.vcs-ref": "5557601",
                "org.label-schema.vcs-url": "https://github.com/aquasecurity/kube-bench",
                "org.label-schema.vendor": "Aqua Security Software Ltd.",
                "org.label-schema.version": "v0.10.0"

@afdesk afdesk requested a review from seanposner January 21, 2025 15:55
@afdesk afdesk merged commit fcfb537 into aquasecurity:main Jan 21, 2025
5 checks passed
@afdesk afdesk deleted the fix/dockerfile-args branch January 21, 2025 16:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants