Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature: Add support for --ignore-unfixed #10

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Feature: Add support for --ignore-unfixed #10

merged 1 commit into from
Jun 22, 2020

Conversation

zoispag
Copy link
Contributor

@zoispag zoispag commented Jun 22, 2020

Closes #9

This PR adds support for --ignore-unfixed run argument.

I took the liberty and updated the README.me to point to tag 0.0.7.

Test

- name: Run scanner with --ignore-fixed=false
  uses: zoispag/trivy-action@master
  if: always()
  with:
    image-ref: 'image'
    exit-code: '1'
    severity: 'MEDIUM'
    ignore-unfixed: false

- name: Run scanner with --ignore-fixed not set
  uses: zoispag/trivy-action@master
  if: always()
  with:
    image-ref: 'image'
    exit-code: '1'
    severity: 'MEDIUM'

- name: Run scanner with --ignore-fixed=true
  uses: zoispag/trivy-action@master
  if: always()
  with:
    image-ref: 'image'
    exit-code: '1'
    severity: 'MEDIUM'
    ignore-unfixed: true

image

  • Run scanner with --ignore-fixed=false executes: docker.io/aquasec/trivy:latest "image" "--format=table" "--ignore-unfixed=false" "--exit-code=1" "--severity=MEDIUM" "image"
  • Run scanner with --ignore-fixed not set executes: docker.io/aquasec/trivy:latest "image" "--format=table" "--ignore-unfixed=false" "--exit-code=1" "--severity=MEDIUM" "image"
  • Run scanner with --ignore-fixed=true executes: docker.io/aquasec/trivy:latest "image" "--format=table" "--ignore-unfixed=true" "--exit-code=1" "--severity=MEDIUM" "image"

@danielpacak danielpacak self-requested a review June 22, 2020 17:37
Copy link
Contributor

@danielpacak danielpacak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @zoispag ! Thank you for contributing and testing the action with different settings 💯

@danielpacak danielpacak merged commit f498173 into aquasecurity:master Jun 22, 2020
@zoispag zoispag deleted the feature/9_add_support_for_ignore-unfixed branch June 22, 2020 18:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add support for --ignore-unfixed
2 participants