Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add token for setup-trivy #421

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Oct 22, 2024

Description

There are cases when we need to overwrite token for actions/checkout in setup-trivy.
e.g. GHES - #418, aquasecurity/setup-trivy#10

So we need to add a token-setup-trivy input to add the ability to override the default token.

test runs:

Related Issues

Related PRs

@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 23, 2024 04:51
@DmitriyLewen DmitriyLewen marked this pull request as draft October 23, 2024 04:51
action.yaml Outdated
Comment on lines 116 to 122
uses: aquasecurity/setup-trivy@v0.2.1
uses: DmitriyLewen/setup-trivy@2df9f605c29dbee29f7c66a8151e3b97f0874f5d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that we should bump this to the next release when the other PR gets merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I used my fork to test the changes.
After setup-trivy is released - I will update this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in -9960a61

@DmitriyLewen DmitriyLewen marked this pull request as ready for review October 24, 2024 05:40
@simar7 simar7 merged commit ee89346 into aquasecurity:master Oct 25, 2024
2 checks passed
@DmitriyLewen DmitriyLewen deleted the feat/token-setup-trivy branch October 25, 2024 05:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while retrieving the default branch name
2 participants