Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(plugin): specify plugin version #6683

Merged
merged 11 commits into from
May 17, 2024

Conversation

knqyf263
Copy link
Collaborator

Description

This PR makes it possible to install plugins with a specified version as below:

$ trivy plugin install referrer@v0.3.0

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

knqyf263 added 4 commits May 14, 2024 14:41
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 self-assigned this May 14, 2024
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 force-pushed the feat/plugin_version branch 3 times, most recently from c23b997 to 32e7db6 Compare May 15, 2024 06:01
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 force-pushed the feat/plugin_version branch from 32e7db6 to ac28cbd Compare May 15, 2024 06:23
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 force-pushed the feat/plugin_version branch from d8f0864 to 7862d49 Compare May 15, 2024 06:48
@knqyf263 knqyf263 marked this pull request as ready for review May 15, 2024 07:26
@knqyf263 knqyf263 requested a review from DmitriyLewen as a code owner May 15, 2024 07:26
@knqyf263
Copy link
Collaborator Author

@DmitriyLewen I was struggling with an error occurring only on GitHub Actions macOS runner, but finally addressed it. It's ready for review.

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Left 1 comment

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 force-pushed the feat/plugin_version branch from 06d085a to 0b1556d Compare May 16, 2024 05:45
Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263 knqyf263 requested a review from DmitriyLewen May 16, 2024 05:53
@DmitriyLewen
Copy link
Contributor

Signed-off-by: knqyf263 <knqyf263@gmail.com>
@knqyf263
Copy link
Collaborator Author

@DmitriyLewen I was struggling with an error occurring only on GitHub Actions macOS runner, but finally addressed it. It's ready for review.

I made the same mistake 😔 Hopefully, it will pass tests this time 🤞

@knqyf263
Copy link
Collaborator Author

@DmitriyLewen Passed!

@knqyf263 knqyf263 added this pull request to the merge queue May 17, 2024
Merged via the queue into aquasecurity:main with commit d6dc567 May 17, 2024
17 checks passed
@knqyf263 knqyf263 deleted the feat/plugin_version branch May 17, 2024 09:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants