Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(java): add support for maven-metadata.xml files for remote snapshot repositories. #6950

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Jun 17, 2024

Description

Add support for maven-metadata.xml files for remote snapshot repositories.
More information and example here - #6412 (comment)

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jun 17, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review June 17, 2024 09:54
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner June 17, 2024 09:54
@knqyf263 knqyf263 added this pull request to the merge queue Jun 19, 2024
Merged via the queue into aquasecurity:main with commit 1f8fca1 Jun 19, 2024
12 checks passed
@DmitriyLewen DmitriyLewen deleted the feat-pom/maven-metadata-xml-for-snapshots branch June 19, 2024 09:13
@@ -14,6 +14,7 @@ import (

multierror "github.com/hashicorp/go-multierror"
"github.com/samber/lo"
"golang.org/x/exp/slices"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to point out we should use slices and started adding a new linter. Then, I forgot to leave a comment😆
Fixed in 2e5cc1f

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(pom.xml): parse maven-metadata.xml files for snapshot repositories.
2 participants