fix: remove webpack-inject-plugin dependency

As mentioned in FriendsOfSymfony#454
ar10642 · Aug 11, 2023 · 21de161 · 21de161
1 parent f527f75
commit 21de161
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 35 deletions.
diff --git a/Resources/package.json b/Resources/package.json
@@ -34,8 +34,8 @@
     "google-closure-library": "^20220104.0.0",
     "gulp": "^4.0.2",
     "gulp-rename": "^2.0.0",
-    "gulp-uglify": "^3.0.2",
     "gulp-typescript": "^6.0.0-alpha.1",
+    "gulp-uglify": "^3.0.2",
     "gulp-wrap": "^0.15.0",
     "jasmine": "^4.0.2",
     "tsd": "^0.19.1",
@@ -47,8 +47,5 @@
     "test": "npm run build && npm run test:types && phantomjs js/run_jsunit.js js/router_test.html",
     "test:types": "tsd",
     "prepublish": "npm run build"
-  },
-  "dependencies": {
-    "webpack-inject-plugin": "^1.5.5"
   }
 }
diff --git a/Resources/public/js/router.js b/Resources/public/js/router.js
@@ -1,22 +1,22 @@
-(function (root, factory) {
-    var routing = factory();
-    if (typeof define === 'function' && define.amd) {
-        // AMD. Register as an anonymous module.
-        define([], routing.Routing);
-    } else if (typeof module === 'object' && module.exports) {
-        // Node. Does not work with strict CommonJS, but
-        // only CommonJS-like environments that support module.exports,
-        // like Node.
-        module.exports = routing.Routing;
-    } else {
-        // Browser globals (root is window)
-        root.Routing = routing.Routing;
-        root.fos = {
-            Router: routing.Router
-        };
-    }
-}(this, function () {
-    var exports = {};
+(function (root, factory) {
+    var routing = factory();
+    if (typeof define === 'function' && define.amd) {
+        // AMD. Register as an anonymous module.
+        define([], routing.Routing);
+    } else if (typeof module === 'object' && module.exports) {
+        // Node. Does not work with strict CommonJS, but
+        // only CommonJS-like environments that support module.exports,
+        // like Node.
+        module.exports = routing.Routing;
+    } else {
+        // Browser globals (root is window)
+        root.Routing = routing.Routing;
+        root.fos = {
+            Router: routing.Router
+        };
+    }
+}(this, function () {
+    var exports = {};
     "use strict";
 exports.__esModule = true;
 exports.Routing = exports.Router = void 0;
@@ -277,7 +277,7 @@ var Router = /** @class */ (function () {
 exports.Router = Router;
 exports.Routing = new Router();
 exports["default"] = exports.Routing;
-
-
-    return { Router: exports.Router, Routing: exports.Routing };
-}));
+
+
+    return { Router: exports.Router, Routing: exports.Routing };
+}));
diff --git a/Resources/public/js/router.min.js b/Resources/public/js/router.min.js
diff --git a/Resources/webpack/FosRouting.js b/Resources/webpack/FosRouting.js
@@ -4,8 +4,7 @@
 const fs = require('fs');
 const path = require('path');
 const util = require('util');
-
-const InjectPlugin = require('webpack-inject-plugin').default;
+const webpack = require("webpack");
 
 const execFile = util.promisify(require('child_process').execFile);
 const readFile = util.promisify(fs.readFile);
@@ -90,11 +89,17 @@ class FosRouting {
             }
         });
 
-        new InjectPlugin(() => {
-            return 'import Routing from "fos-router";' +
-                'import routes from '+JSON.stringify(this.finalTarget)+';' +
-                'Routing.setRoutingData(routes);';
-        }).apply(compiler);
+        new webpack.BannerPlugin({
+            entryOnly: true,
+            include: this.finalTarget ? this.finalTarget + ".js" : /\.js$/,
+            raw: true,
+            banner:
+              'import Routing from "fos-router";' +
+              "import routes from " +
+              JSON.stringify(this.finalTarget) +
+              ";" +
+              "Routing.setRoutingData(routes);",
+          }).apply(compiler);
     }
 }