fix: remove webpack-inject-plugin dependency

As mentioned in FriendsOfSymfony#454
ar10642 · Aug 11, 2023 · e2c2c7e · e2c2c7e
1 parent f527f75
commit e2c2c7e
Show file tree

Hide file tree

Showing 3 changed files with 106 additions and 86 deletions.
diff --git a/Resources/package.json b/Resources/package.json
@@ -34,8 +34,8 @@
     "google-closure-library": "^20220104.0.0",
     "gulp": "^4.0.2",
     "gulp-rename": "^2.0.0",
-    "gulp-uglify": "^3.0.2",
     "gulp-typescript": "^6.0.0-alpha.1",
+    "gulp-uglify": "^3.0.2",
     "gulp-wrap": "^0.15.0",
     "jasmine": "^4.0.2",
     "tsd": "^0.19.1",
@@ -47,8 +47,5 @@
     "test": "npm run build && npm run test:types && phantomjs js/run_jsunit.js js/router_test.html",
     "test:types": "tsd",
     "prepublish": "npm run build"
-  },
-  "dependencies": {
-    "webpack-inject-plugin": "^1.5.5"
   }
 }
diff --git a/Resources/public/js/router.min.js b/Resources/public/js/router.min.js
diff --git a/Resources/webpack/FosRouting.js b/Resources/webpack/FosRouting.js
@@ -1,101 +1,124 @@
 /**
  * @author Adrien Foulon <tofandel@tukan.hu>
  */
-const fs = require('fs');
-const path = require('path');
-const util = require('util');
+const fs = require("fs");
+const path = require("path");
+const util = require("util");
+const webpack = require("webpack");
 
-const InjectPlugin = require('webpack-inject-plugin').default;
-
-const execFile = util.promisify(require('child_process').execFile);
+const execFile = util.promisify(require("child_process").execFile);
 const readFile = util.promisify(fs.readFile);
 const rmFile = util.promisify(fs.rm);
 const writeFile = util.promisify(fs.writeFile);
-const makeDir = util.promisify(fs.mkdir)
+const makeDir = util.promisify(fs.mkdir);
 
 class FosRouting {
-    default = {
-        locale: '',
-        prettyPrint: false,
-        domain: [],
-        php: 'php',
-    };
+  default = {
+    locale: "",
+    prettyPrint: false,
+    domain: [],
+    php: "php",
+  };
 
-    constructor(options = {}) {
-        this.options = Object.assign({target: 'var/cache/fosRoutes.json'}, this.default, options, {format: 'json'});
-        this.finalTarget = path.resolve(process.cwd(), this.options.target);
-        this.options.target = path.resolve(process.cwd(), this.options.target.replace(/\.json$/, '.tmp.json'));
+  constructor(options = {}) {
+    this.options = Object.assign(
+      { target: "var/cache/fosRoutes.json" },
+      this.default,
+      options,
+      { format: "json" }
+    );
+    this.finalTarget = path.resolve(process.cwd(), this.options.target);
+    this.options.target = path.resolve(
+      process.cwd(),
+      this.options.target.replace(/\.json$/, ".tmp.json")
+    );
 
-        if (this.options.target === this.finalTarget) {
-            this.options.target += '.tmp';
-        }
+    if (this.options.target === this.finalTarget) {
+      this.options.target += ".tmp";
     }
+  }
 
-    // Values don't need to be escaped because node already does that
-    shellArg(key, value) {
-        key = this.kebabize(key);
-        return typeof value === 'boolean' ? (value ? '--' + key : '') : '--' + key + '=' + value;
-    }
+  // Values don't need to be escaped because node already does that
+  shellArg(key, value) {
+    key = this.kebabize(key);
+    return typeof value === "boolean"
+      ? value
+        ? "--" + key
+        : ""
+      : "--" + key + "=" + value;
+  }
 
-    kebabize(str) {
-        return str.split('').map((letter, idx) => {
-            return letter.toUpperCase() === letter
-                ? `${idx !== 0 ? '-' : ''}${letter.toLowerCase()}`
-                : letter;
-        }).join('');
-    }
+  kebabize(str) {
+    return str
+      .split("")
+      .map((letter, idx) => {
+        return letter.toUpperCase() === letter
+          ? `${idx !== 0 ? "-" : ""}${letter.toLowerCase()}`
+          : letter;
+      })
+      .join("");
+  }
 
-    apply(compiler) {
-        let prevContent = null;
-        try {
-            fs.readFileSync(this.finalTarget);
-        } catch (e) {
+  apply(compiler) {
+    let prevContent = null;
+    try {
+      fs.readFileSync(this.finalTarget);
+    } catch (e) {}
+    const compile = async (comp, callback) => {
+      const args = Object.keys(this.options).reduce((pass, key) => {
+        const val = this.options[key];
+        if (val !== this.default[key]) {
+          if (Array.isArray(val)) {
+            pass.push(...val.map((v) => this.shellArg(key, v)));
+          } else {
+            pass.push(this.shellArg(key, val));
+          }
+        }
+        return pass;
+      }, []);
+      await execFile(this.options.php, [
+        "bin/console",
+        "fos:js-routing:dump",
+        ...args,
+      ]);
+      try {
+        const content = await readFile(this.options.target);
+        await rmFile(this.options.target);
+        if (!prevContent || content.compare(prevContent) !== 0) {
+          await makeDir(path.dirname(this.finalTarget), { recursive: true });
+          await writeFile(this.finalTarget, content);
+          prevContent = content;
+          if (comp.modifiedFiles && !comp.modifiedFiles.has(this.finalTarget)) {
+            comp.modifiedFiles.add(this.finalTarget);
+          }
         }
-        const compile = async (comp, callback) => {
-            const args = Object.keys(this.options).reduce((pass, key) => {
-                const val = this.options[key];
-                if (val !== this.default[key]) {
-                    if (Array.isArray(val)) {
-                        pass.push(...val.map((v) => this.shellArg(key, v)));
-                    } else {
-                        pass.push(this.shellArg(key, val));
-                    }
-                }
-                return pass;
-            }, []);
-            await execFile(this.options.php, ['bin/console', 'fos:js-routing:dump', ...args]);
-            try {
-                const content = await readFile(this.options.target);
-                await rmFile(this.options.target);
-                if (!prevContent || content.compare(prevContent) !== 0) {
-                    await makeDir(path.dirname(this.finalTarget), {recursive: true});
-                    await writeFile(this.finalTarget, content);
-                    prevContent = content;
-                    if (comp.modifiedFiles && !comp.modifiedFiles.has(this.finalTarget)) {
-                        comp.modifiedFiles.add(this.finalTarget);
-                    }
-                }
-            } catch (e) {
-                const logger = compiler.getInfrastructureLogger('FosRouting');
-                logger.error(e.toString());
-            }
-            callback();
-        };
-        compiler.hooks.beforeRun.tapAsync('RouteDump', compile);
-        compiler.hooks.watchRun.tapAsync('RouteDump_Watch', (comp, callback) => {
-            if (!comp.modifiedFiles || !comp.modifiedFiles.has(this.finalTarget)) {
-                compile(comp, callback);
-            } else {
-                callback();
-            }
-        });
+      } catch (e) {
+        const logger = compiler.getInfrastructureLogger("FosRouting");
+        logger.error(e.toString());
+      }
+      callback();
+    };
+    compiler.hooks.beforeRun.tapAsync("RouteDump", compile);
+    compiler.hooks.watchRun.tapAsync("RouteDump_Watch", (comp, callback) => {
+      if (!comp.modifiedFiles || !comp.modifiedFiles.has(this.finalTarget)) {
+        compile(comp, callback);
+      } else {
+        callback();
+      }
+    });
 
-        new InjectPlugin(() => {
-            return 'import Routing from "fos-router";' +
-                'import routes from '+JSON.stringify(this.finalTarget)+';' +
-                'Routing.setRoutingData(routes);';
-        }).apply(compiler);
-    }
+    new webpack.BannerPlugin({
+      entryOnly: true,
+      include: this.finalTarget ? this.finalTarget + ".js" : /\.js$/,
+      raw: true,
+      banner:
+        'import Routing from "fos-router";' +
+        "import routes from " +
+        JSON.stringify(this.finalTarget) +
+        ";" +
+        "Routing.setRoutingData(routes);",
+    }).apply(compiler);
+  }
 }
 
 module.exports = FosRouting;