Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(APP-3801): Update NumberFormat.TOKEN_AMOUNT_SHORT to round small numbers (between -0.01 and 0.01) to the nearest hundredth #413

Merged
merged 9 commits into from
Feb 25, 2025

Conversation

shan8851
Copy link
Contributor

@shan8851 shan8851 commented Feb 24, 2025

Description

Update NumberFormat.TOKEN_AMOUNT_SHORT to round small numbers (between -0.01 and 0.01) to the nearest hundredth

Task: APP-3801

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • Updated the CHANGELOG.md file after the [UPCOMING] title and before the latest version
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

@shan8851 shan8851 requested a review from a team February 24, 2025 12:53
thekidnamedkd
thekidnamedkd previously approved these changes Feb 24, 2025
Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one possible idea. Thanks! ✨

Copy link
Contributor

@thekidnamedkd thekidnamedkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@shan8851 shan8851 merged commit 7c5ff70 into main Feb 25, 2025
4 checks passed
@shan8851 shan8851 deleted the feat/app-3801 branch February 25, 2025 21:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants