Skip to content

Add TTL option to Export #189

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Conversation

b-gretsch
Copy link

For exports of big collections users may want to increase the cursor's TTL to a bigger value without having to change the server default.

@tomterl
Copy link
Contributor

tomterl commented May 2, 2016

If new functionality and grammar/spelling corrections are done, I prefer multiple commits, separating the different types of change.

@frankmayer
Copy link
Contributor

@b-gretsch Thanks for this PR.
I would normally agree with @tomterl on this one, however, since this is a really old PR that slipped through, I think it's OK to let this one through without going through the separation process.

However there are a few more steps to get this merged:

  1. Provide a test which uses this added functionality
  2. Resolve conflicts.
  3. Provide the ArangoDB company with a signed CLA, see https://github.com/arangodb/arangodb-php/blob/devel/CONTRIBUTING.md

@frankmayer
Copy link
Contributor

@b-gretsch are you still interested in completing this PR?

@frankmayer
Copy link
Contributor

This PR seems abandoned. Leaving it open for consideration of implementing such functionality.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants